Skip to content

Conversation

@longhuan-cisco
Copy link
Contributor

@longhuan-cisco longhuan-cisco commented Sep 23, 2025

Description

Add is_lpo API to check if the module is Linear Pluggable Optics (LPO)

Motivation and Context

This API will be consumed by sonic-net/sonic-platform-daemons#687

How Has This Been Tested?

Additional Information (Optional)

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

LowPwrRequestSW = 4
LowPwrAllowRequestHW = 6

LPO_HOST_ELECTRICAL_INTERFACE_IDS = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@longhuan-cisco which SFF spec version are you using?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prgeor
The code here is based on today's sonic_platform_base/sonic_xcvr/codes/public/sff8024.py:

32: 'LEI-100G-PAM4-1',
33: 'LEI-200G-PAM4-2',
34: 'LEI-400G-PAM4-4',
35: 'LEI-800G-PAM4-8',

151: "100G-DR1-LPO",
152: "200G-DR2-LPO",
153: "400G-DR4-LPO",
154: "800G-DR8-LPO",

But according to latest rev4.13 July 11, 2025 version of SFF-8024, MEDIA_INTERFACE_IDS for LPO starting from 143:
Image
I think we need to update sonic_platform_base/sonic_xcvr/codes/public/sff8024.py, will raise a PR about this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a PR #596 to update LPO media codes in sonic_platform_base/sonic_xcvr/codes/public/sff8024.py based on latest SFF-8024.
Will update lpo API accordingly.

Copy link
Contributor

@mihirpat1 mihirpat1 Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@longhuan-cisco @prgeor I corrected the LPO related IDs since this change was causing test failures for #596

@prgeor prgeor merged commit 320c11b into sonic-net:master Oct 1, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants