-
Notifications
You must be signed in to change notification settings - Fork 200
Add API to check if module is Linear Pluggable Optics (LPO) #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
789e40a to
ae64feb
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| LowPwrRequestSW = 4 | ||
| LowPwrAllowRequestHW = 6 | ||
|
|
||
| LPO_HOST_ELECTRICAL_INTERFACE_IDS = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@longhuan-cisco which SFF spec version are you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prgeor
The code here is based on today's sonic_platform_base/sonic_xcvr/codes/public/sff8024.py:
sonic-platform-common/sonic_platform_base/sonic_xcvr/codes/public/sff8024.py
Lines 221 to 224 in 1ccb062
| 32: 'LEI-100G-PAM4-1', | |
| 33: 'LEI-200G-PAM4-2', | |
| 34: 'LEI-400G-PAM4-4', | |
| 35: 'LEI-800G-PAM4-8', |
sonic-platform-common/sonic_platform_base/sonic_xcvr/codes/public/sff8024.py
Lines 415 to 418 in 1ccb062
| 151: "100G-DR1-LPO", | |
| 152: "200G-DR2-LPO", | |
| 153: "400G-DR4-LPO", | |
| 154: "800G-DR8-LPO", |
But according to latest rev4.13 July 11, 2025 version of SFF-8024, MEDIA_INTERFACE_IDS for LPO starting from 143:

I think we need to update sonic_platform_base/sonic_xcvr/codes/public/sff8024.py, will raise a PR about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's already a PR #596 to update LPO media codes in sonic_platform_base/sonic_xcvr/codes/public/sff8024.py based on latest SFF-8024.
Will update lpo API accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@longhuan-cisco @prgeor I corrected the LPO related IDs since this change was causing test failures for #596
Description
Add
is_lpoAPI to check if the module is Linear Pluggable Optics (LPO)Motivation and Context
This API will be consumed by sonic-net/sonic-platform-daemons#687
How Has This Been Tested?
Additional Information (Optional)