Skip to content

update pice_base.py #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update pice_base.py #56

wants to merge 1 commit into from

Conversation

carycelestica
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Aug 22, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

keboliu
keboliu reviewed Sep 11, 2019
View reviewed changes
sonic_platform_base/pcie_base.py
class PcieBase(object):
__metaclass__ = abc.ABCMeta

@abc.abstractmethod
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need "@abc.abstractmethod"?

keboliu
keboliu requested changes Sep 11, 2019
View reviewed changes
Copy link
Collaborator

@keboliu keboliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
@kuanyu99
[syseepromd] Prevent the syseepromd from termination (sonic-net#56)
5b14368 
Since the termination of the syseepromd will lead to the termination of the pmon.
Regularly try to update the eeprom data, instead of exiting the syseepromd directly when the update_eeprom_to_db return with failure.
Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-platform-common that referenced this pull request May 7, 2025
@mssonicbld
[code sync] Merge code from sonic-net/sonic-platform-common:202411 to…
b37907d 
… 202412 (sonic-net#56)

```<br>* 8aa4a87 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-08) [Sonic Automation]
* f679a67 - (origin/202411) Restore optoe page to default 0 for active cables (sonic-net#550) (2025-03-04) [mssonicbld]
* c735073 - [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin]
* b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keboliu keboliu keboliu requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Enhancement PCIe

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carycelestica @msftclas @keboliu @jleveque