fix(sfp): fix rx power conversion #479
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes sonic-net#449 Signed-off-by: Wataru Ishida <[email protected]>
ishidawataru
force-pushed
the
fix-rx-power
branch
from
e942705 to
f3db323
Compare
JaapKeuter
reviewed
Jul 14, 2024
| coeff = self.float_from_bytes(eeprom_data[off:off+size]) | ||
| result += coeff * rx_pwr_ad ** i | ||
|
|
||
| result = result * 0.0001 # uW to mW |
There was a problem hiding this comment.
Here the comment should make it clear that the result value is in 0.1 uW units, not uW (the formula in the documentation at section 9.3 is also misleading in that regards). Otherwise the conversion factor may be interpreted off by an order of magnitude by an unsuspecting reader.
|
@ishidawataru : See my feedback in the related issue 449 |
|
This code has been tested, see issue 449, and found to be correct. The only remark is about a comment in the code. With a changed comment this code should be merged, IMHO. |
|
@ishidawataru : Could you pay attention to this change, i.e. finalizing the draft and putting it forward for merging please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes how to calculate the rx power when the external calibration is used according to the SFF-8472 Rev 12.4 section 9.3.
Motivation and Context
fixes #449
How Has This Been Tested?
No. Asking the original reporter of this bug to test this as I don't have access to a real device that uses this feature
Additional Information (Optional)