Bind default namespace database container to midplane ip #23837
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft @arlakshm @judyjoseph please review. This is a continuation of: #20803 for single ASIC linecards |
|
can we update PR subject as this is more of infrastructure change |
|
@manish1-arista Did we make sure it is not impacting exiting T2 VoQ stats aggregation? Also, please update subject as per Abhishek comment. |
manish1-arista
changed the title
Updated |
Yes, we have verified this. The changes do not cause any regressions to the existing T2 VoQ stats aggregation. |
| {%- if docker_container_name == "database" %} | ||
| midplane_ip="" | ||
| CHASSISDB_CONF="/usr/share/sonic/device/$PLATFORM/chassisdb.conf" | ||
| if [[ -f $CHASSISDB_CONF ]]; then |
There was a problem hiding this comment.
add check for $DATABASE_TYPE != "dpudb"
| if [[ $DEV && $midplane_ip ]]; then | ||
| # Binding the midplane ip to the redisdb | ||
| if [[ -n "$midplane_ip" ]]; then | ||
| IFS=_ read ip port < <(jq -r '.INSTANCES | [.redis.hostname, .redis.port] | join("_")' /var/run/redis$DEV/sonic-db/database_config.json) |
There was a problem hiding this comment.
here we are looking at "/var/run/redis$DEV/sonic-db/database_config.json", $DEV for host is empty? Can you confirm
|
@manish1-arista, please add to PR description(How did you verify) before and after test results of this change in communication between LC host database <--> chassis db in sup |
|
/azp run |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
On a linecard, the database container is bound to localhost (127.0.0.1) by default. This prevents other components in the chassis, such as the supervisor card, from accessing the linecard's database over the midplane network. This change exposes the database instance to the midplane, allowing for remote access from the supervisor. Signed-off-by: manish <[email protected]>
manish1-arista
force-pushed
the
bind_linecard_db_to_midplane_ip
branch
from
fcde75e to
d23b8db
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 participants
This feature has been tracked at: sonic-net/SONiC#2020
Why I did it
On a linecard, the default namespace database container is only bound to localhost (127.0.0.1).
This prevents other components in the chassis, such as the supervisor card,
from accessing the linecard's default namespace database over the midplane network to aggregate the VOQ counters for Single ASIC Linecards.
Work item tracking
How I did it
Set the protected-mode no and bind the linecard's eth1-midplane IP address to the default namespace database container, allowing for remote access from the supervisor to collect the VOQ counters.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Master
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)