feat: Emit Events for Monitoring State Resets#299
Merged
hman38705 merged 2 commits intosolutions-plug:mainfrom Mar 26, 2026
Merged
feat: Emit Events for Monitoring State Resets#299hman38705 merged 2 commits intosolutions-plug:mainfrom
hman38705 merged 2 commits intosolutions-plug:mainfrom
Conversation
|
@Macnelson9 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
Adds on-chain transparency for monitoring resets by emitting a detailed reset event whenever monitoring counters are cleared. The event includes both historical counter values and the resetter identity for auditability.
🎯 Type of Change
🔗 Related Issues
Closes #152
📝 Changes Made
emit_monitoring_state_resetevent helper in events.rs.reset_monitoringto capture previous monitoring counters, clear state, and emit the new detailed event in monitoring.rs.track_errorto persistLastObservationtimestamp for accurate reset reporting in monitoring.rs.🧪 Testing
Test Coverage
Manual Testing
Test Results:
Added tests verify:
ErrorCountandLastObservationare cleared after reset.mon_resetevent is emitted and contains historical counter values.File-level diagnostics show no errors in modified files.
📸 Screenshots (if applicable)
Not applicable (no UI changes).
✅ Checklist
Code Quality
Documentation
Testing & Quality
Security
Git
🔍 Reviewer Notes
Please focus review on:
mon_resetand indexer compatibility.📊 Performance Impact
Details:
Only lightweight storage reads/writes and one additional event emission were introduced on reset.
🚀 Deployment Notes
No migration or config changes required.
Safe to deploy as a backward-compatible observability enhancement.
📚 Additional Context
Primary files changed:
Suggested commit message:
feat: emit on-chain events when monitoring counters are reset
By submitting this PR, I confirm that: