Fix credentials filtering with no allowList

[lunt7]

getAssertionState.creds[ALLOW_LIST_MAX_SIZE] has space for
ALLOW_LIST_MAX_SIZE credentials but we are only filling it up to
ALLOW_LIST_MAX_SIZE - 1

[conorpp]

Since C arrays start at 0, I believe GA->creds[ALLOW_LIST_MAX_SIZE - 1]; is the last element?

[jolo1581]

@conorpp you are right n-1 ist the last element of the array. But in this case this is an error exception if your counter is outside array size. So n-1 is valid and n not.

Also it is not a good style asking for equal. Better it would be:

if (count > ALLOW_LIST_MAX_SIZE-1)

or

if (count >= ALLOW_LIST_MAX_SIZE)

So If @lunt7 would correct this to one of the example above and it would be right.

Greetz Jan

[lunt7]

There is a similar condition checking in save_credential_list(), so I decided to go with the first one to be consistent.