Default to .aab builds with Play Store #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey thanks for the PR. This is definitely something we want to support, but probably would be good to make it a user decision, which option to choose from. It would require adding a prompt and changing the template depending on the choice. Would you be willing to add that? |
Author
|
Sure! |
Author
|
@eduplus Added a prompt to select the build variant. Additionally, I feel like the |
Contributor
|
Thanks, this looks good to me, @miguelrrc promised to check that it works with his (long in waiting) PR, which does a lot on Android side as well. Hopefully we can merge these both in soon. |
Collaborator
|
It is good to go! 👍 |
adeadavid
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed template Fastfile to use Android App Bundle as default.
Reasons to use .aab include smaller app size and no need to build for separate CPU architectures, as that is handled by the Play Store.
More info here:
https://developer.android.com/platform/technology/app-bundle
As of now, Crashlytics does not support .aab -format.