make PSReadIC test for more IC coverage#294
Conversation
|
Pass all tests |
mungerct
added
the
regression-test
bsrunnels
left a comment
bsrunnels
left a comment
There was a problem hiding this comment.
Isn't IC::PSRead already used in tests/SCPSpheresElastic?
We should probably determine why the coverage report isn't reflecting the PSRead call in that test and fix that issue rather than add a new test.
(And if adding a brief test like this is the solution, I suggest we simply add it as a section to the existing SCPSpheresElastic test rather than an entire new test.)
|
Looking into why the converge report doesn't show PSRead, will edit the test to be included in the SCPSpheresElastic test. Currently multiple features of PSRead aren't tested such as mult, offset, and invert and I want to add coverage to them |
|
Removed the test and added it to the SCPSpheresElastic, and we now test all of the psread functionality, including mult, invert, and x0 which were not tested before |
|
Pass all tests |
2 participants
Make a test case for the PSRead IC, total test runs in >5 seconds and adds needed coverage.