Skip to content

Adhesion#140

Open
nimasina-innovation wants to merge 23 commits into
developmentfrom
adhesion
Open

Adhesion#140
nimasina-innovation wants to merge 23 commits into
developmentfrom
adhesion

Conversation

@nimasina-innovation

Copy link
Copy Markdown

Pull request for adhesion model.

@bsrunnels bsrunnels left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A regression test is needed before this can be merged into development.
Also, please address the failing installation test.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting in this file is noncompliant with the style outlined in .clang-format.

@@ -0,0 +1,225 @@

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add documentation at the top of this file to outline the method. See Model::Solid::Affine::J2 for an example of suitable documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants