Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about destructuring breaking reactivity #986

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

brenelz
Copy link
Collaborator

@brenelz brenelz commented Dec 17, 2024

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

Add actual destructuring example

Related issues & labels

Copy link

stackblitz bot commented Dec 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 26a3bab
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6760bf5556488a0008674903
😎 Deploy Preview https://deploy-preview-986--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit e61ac00
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6760bf63266d5700082edc29
😎 Deploy Preview https://deploy-preview-986--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes LadyBluenotes merged commit cba901d into solidjs:main Dec 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Content]: The example that explains why not to destruct props is not actually destructing
2 participants