Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createBatch reference doc rewrite #982

Merged
merged 7 commits into from
Dec 18, 2024
Merged

createBatch reference doc rewrite #982

merged 7 commits into from
Dec 18, 2024

Conversation

edemaine
Copy link
Contributor

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

Flesh out batch reference docs. Highlights:

  • Code examples
  • Asymptotic performance analysis
  • Interactive with memos
  • Implementation details and impact on nesting and await (the latter was recently a topic on Discord)

* Code examples
* Asymptotic performance analysis
* Interactive with memos
* Implementation details and impact on nesting and `await`
Copy link

stackblitz bot commented Dec 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 13fd29d
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6761ce8ab762eb0008d859a1
😎 Deploy Preview https://deploy-preview-982--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes
Copy link
Member

These good to merge now @edemaine?

@edemaine
Copy link
Contributor Author

edemaine commented Dec 17, 2024

I was waiting for a response on #592 but it should be good to go now! Very minor edit since your last review.

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) December 18, 2024 01:18
@LadyBluenotes LadyBluenotes merged commit d2978b5 into main Dec 18, 2024
8 checks passed
@LadyBluenotes LadyBluenotes deleted the batch-rewrite branch December 18, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants