Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect 'state' example from create-resource.mdx #979

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

cheriot
Copy link
Contributor

@cheriot cheriot commented Dec 8, 2024

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

Example code for createResource includes a state attribute on the second return value that is actually on the first.

Related issues & labels

  • Closes #
  • Suggested label(s) (optional): documentation

Copy link

stackblitz bot commented Dec 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit e1a48aa
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/675509442c3bd800088b5fa7
😎 Deploy Preview https://deploy-preview-979--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cheriot cheriot changed the title Remove incorrect 'state' usage from create-resource.mdx Remove incorrect 'state' example from create-resource.mdx Dec 8, 2024
Copy link
Contributor

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edemaine edemaine merged commit 1f0d66b into solidjs:main Dec 14, 2024
8 checks passed
@cheriot cheriot deleted the patch-1 branch December 15, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants