Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to SolidBase tabs and package helper #1135

Merged
merged 11 commits into from
Mar 27, 2025
Merged

Migrate to SolidBase tabs and package helper #1135

merged 11 commits into from
Mar 27, 2025

Conversation

amirhhashemi
Copy link
Collaborator

@amirhhashemi amirhhashemi commented Mar 19, 2025 •
edited
Loading

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

This PR:

  • Replaces package manager instructions with the SolidBase's package- syntax.
  • Uses the new syntax for tabs

Related issues & labels

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 19, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@amirhhashemi amirhhashemi requested a review from jer3m01 March 19, 2025 17:34
@netlify Netlify
Copy link

netlify bot commented Mar 19, 2025 •
edited
Loading

✅ Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 9bfaf5c
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67e5baeb245a5b0008e368e9
😎 Deploy Preview https://deploy-preview-1135--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amirhhashemi amirhhashemi changed the title Migrate to SolidBase's package helpers Migrate to SolidBase tabs and package helper Mar 19, 2025
jer3m01
jer3m01 requested changes Mar 19, 2025
View reviewed changes
Copy link
Member

@jer3m01 jer3m01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exec, global install and create are a nice idea, I'll probably port it back to SolidBase.

There's a small temporary change to make below.

@amirhhashemi amirhhashemi mentioned this pull request Mar 22, 2025
Open
@LadyBluenotes LadyBluenotes requested a review from jer3m01 March 26, 2025 23:47
jer3m01
jer3m01 approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@jer3m01 jer3m01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Maybe a small styling change to make the tabs scroll on small screens?
Screenshot_20250327_100636_Firefox

@amirhhashemi
Copy link
Collaborator Author

@jer3m01 It should be fixed now

jer3m01
jer3m01 approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@jer3m01 jer3m01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) March 27, 2025 20:53
@LadyBluenotes LadyBluenotes merged commit 01c661f into solidjs:main Mar 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jer3m01 jer3m01 jer3m01 approved these changes

@LadyBluenotes LadyBluenotes LadyBluenotes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Other]: Add a PackageManager component
3 participants
@amirhhashemi @jer3m01 @LadyBluenotes