Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update produce.mdx: Clarify meaning of "local mutation" #1120

Merged
merged 5 commits into from
Mar 16, 2025

Conversation

klequis
Copy link
Contributor

@klequis klequis commented Mar 11, 2025

I didn't relate to the term "local mutation" and that could just be a function of my experience (or lack thereof) but I asked about it on Discord and got a great answer from @fabiospampinato: Local mutation, at least in this context, means "[you can] mutate the store inside the produce function".

I'm suggesting changed the doc to remove the term "local mutation" and replace it with @fabiospampinto's definition. However, if you think "local mutation" is relatable to most readers of the docs just let me know and I'll close the issue.

Discord link: https://discord.com/channels/722131463138705510/861229287868858379/1348946097430728725

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

Related issues & labels

  • Closes #
  • Suggested label(s) (optional):

I didn't relate to the term "local mutation" and that could just be a function of my experience (or lack thereof) but I asked about it on Discord and got a great answer from @fabiospampinato: Local mutation, at lease in this context, means "[you can] mutate the store inside the produce function". 

I'm suggesting changed the doc to remove the term "local mutation" and replace it with @fabiospampinto's definition. However, if you think "local mutation" is relatable to most readers of the docs just let me know and I'll close the issue.

Discord link: https://discord.com/channels/722131463138705510/861229287868858379/1348946097430728725
Copy link

stackblitz bot commented Mar 11, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 31efc0b
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67d72faccef4f9000891160b
😎 Deploy Preview https://deploy-preview-1120--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) March 16, 2025 20:08
@LadyBluenotes LadyBluenotes merged commit 0ee083f into solidjs:main Mar 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants