Skip to content

πŸ› λ©˜ν†  νŽ˜μ΄μ§€ μ§„μž… μ‹œ authStore 반영 λˆ„λ½ μˆ˜μ •#423

Merged
manNomi merged 6 commits intomainfrom
fix/mentor-authstore-sync-main
Feb 14, 2026
Merged

πŸ› λ©˜ν†  νŽ˜μ΄μ§€ μ§„μž… μ‹œ authStore 반영 λˆ„λ½ μˆ˜μ •#423
manNomi merged 6 commits intomainfrom
fix/mentor-authstore-sync-main

Conversation

@manNomi
Copy link
Contributor

@manNomi manNomi commented Feb 14, 2026

Summary

  • λ©˜ν†  νŽ˜μ΄μ§€/μ±„νŒ… μ§„μž… μ‹œ accessToken 반영 타이밍 문제둜 authStoreκ°€ λΉ„μ–΄ μžˆμ„ λ•Œ λ°œμƒν•˜λŠ” 였λ₯˜λ₯Ό μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
  • axios μš”μ²­ μΈν„°μ…‰ν„°μ—μ„œ refreshStatus 기반으둜 μž¬λ°œκΈ‰ μ‹œλ„λ₯Ό 보강해 초기 μ§„μž… μ‹œμ μ—λ„ authStoreκ°€ λ™κΈ°ν™”λ˜λ„λ‘ ν–ˆμŠ΅λ‹ˆλ‹€.
  • μ±„νŒ… κ΄€λ ¨ μ»΄ν¬λ„ŒνŠΈμ—μ„œ useAuthStore.getState() λ‹¨λ°œ 쑰회λ₯Ό ꡬ독 λ°©μ‹μœΌλ‘œ λ°”κΏ” 토큰 갱신을 μ¦‰μ‹œ λ°˜μ˜ν•˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

Changes

  • apps/web/src/utils/axiosInstance.ts
    • 토큰 λΆ€μž¬ μ‹œ refreshStatus !== \"failed\" μ‘°κ±΄μ—μ„œ μž¬λ°œκΈ‰ μ‹œλ„
    • μž¬λ°œκΈ‰ 흐름에 setRefreshStatus(\"refreshing\" | \"success\" | \"failed\") 반영
    • μž¬λ°œκΈ‰ ν›„ μ΅œμ‹  store μƒνƒœλ‘œ 인증 헀더/λ¦¬λ‹€μ΄λ ‰νŠΈ νŒλ‹¨
  • apps/web/src/lib/web-socket/useConnectWebSocket.ts
    • accessToken, isInitializedλ₯Ό store κ΅¬λ…κ°’μœΌλ‘œ μ‚¬μš©
    • μ΄ˆκΈ°ν™”/토큰 λŒ€κΈ° μƒνƒœμ—μ„œ Pending μœ μ§€ ν›„ 토큰 반영 μ‹œ μž¬μ—°κ²°
  • apps/web/src/app/mentor/chat/[chatId]/_ui/ChatNavBar/index.tsx
    • useAuthStore((state) => state.accessToken) κ΅¬λ…μœΌλ‘œ μ—­ν•  계산 동기화

Verification

  • pnpm --filter @solid-connect/web run typecheck
  • pnpm --filter @solid-connect/web run build
  • pre-commit ν›… pnpm run ci:check 톡과
  • pre-push ν›… pnpm --filter @solid-connect/web run build 톡과

@vercel
Copy link

vercel bot commented Feb 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-web-admin Error Error Feb 14, 2026 0:53am
solid-connection-web Error Error Feb 14, 2026 0:53am

@github-actions github-actions bot added the web label Feb 14, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 14, 2026

Warning

Rate limit exceeded

@manNomi has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 31 seconds before requesting another review.

βŒ› How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

이번 변경사항은 인증 μƒνƒœ κ΄€λ¦¬μ˜ 일관성을 높이기 μœ„ν•΄ 토큰 검색 및 μž¬λ°œκΈ‰ λ‘œμ§μ„ κ°œμ„ ν•˜λŠ” μž‘μ—…μž…λ‹ˆλ‹€. μ„Έ 개 νŒŒμΌμ— 걸쳐 이루어진 λ³€κ²½ λ‚΄μš©μ€ λ‹€μŒκ³Ό κ°™μŠ΅λ‹ˆλ‹€:

  1. ChatNavBar μ»΄ν¬λ„ŒνŠΈμ˜ 토큰 μ ‘κ·Ό 방식 κ°œμ„ 

    • μ „μ—­ μƒνƒœ κ²Œν„°λ₯Ό ν†΅ν•œ 직접 μ ‘κ·Όμ—μ„œ React ν›… 기반의 μ„ νƒμž μ ‘κ·ΌμœΌλ‘œ λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.
    • κΈ°μ‘΄ νŒŒμ‹± 및 μ—­ν•  확인 λ‘œμ§μ€ μœ μ§€λ©λ‹ˆλ‹€.
  2. WebSocket μ—°κ²° μ „ 인증 μƒνƒœ 검증 μΆ”κ°€

    • useConnectWebSocket ν›…μ—μ„œ accessTokenκ³Ό isInitializedλ₯Ό 미리 ν™•μΈν•˜λ„λ‘ λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.
    • μ΄ˆκΈ°ν™”λ˜μ§€ μ•Šμ•˜κ±°λ‚˜ 토큰이 μ—†μœΌλ©΄ 연결을 μ‹œλ„ν•˜μ§€ μ•Šκ³  μƒνƒœλ₯Ό Pending으둜 μ„€μ •ν•©λ‹ˆλ‹€.
    • μ˜μ‘΄μ„± 배열에 accessTokenκ³Ό isInitializedλ₯Ό μΆ”κ°€ν•˜μ—¬ 인증 μƒνƒœ λ³€κ²½ μ‹œ μž¬μ—°κ²°ν•©λ‹ˆλ‹€.
  3. Axios μš”μ²­ μΈν„°μ…‰ν„°μ˜ 토큰 μž¬λ°œκΈ‰ 둜직 λ¦¬νŒ©ν† λ§

    • isInitialized 기반 μ ‘κ·Όμ—μ„œ refreshStatus 기반의 μ„ΈλΆ„ν™”λœ νλ¦„μœΌλ‘œ μ „ν™˜ν–ˆμŠ΅λ‹ˆλ‹€.
    • 토큰 μž¬λ°œκΈ‰ μ‹œ refreshing, success, failed μƒνƒœλ₯Ό κ΄€λ¦¬ν•˜λ©° 투λͺ…ν•œ μƒνƒœ 좔적을 보μž₯ν•©λ‹ˆλ‹€.
    • μ΅œμ’… 둜그인 λ¦¬λ‹€μ΄λ ‰νŠΈ νŒλ‹¨μ„ ν˜„μž¬μ˜ μ΄ˆκΈ°ν™” μƒνƒœμ™€ 토큰 쑴재 μ—¬λΆ€λ‘œ κ²°μ •ν•©λ‹ˆλ‹€.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested reviewers

  • wibaek
  • enunsnv
  • khwww
πŸš₯ Pre-merge checks | βœ… 4
βœ… Passed checks (4 passed)
Check name Status Explanation
Title check βœ… Passed PR 제λͺ©μ΄ μ£Όμš” λ³€κ²½ 사항을 λͺ…ν™•ν•˜κ²Œ μš”μ•½ν•˜κ³  있으며, λ©˜ν†  νŽ˜μ΄μ§€ μ§„μž… μ‹œ authStore 반영 문제 μˆ˜μ •μ΄λΌλŠ” 핡심 λ‚΄μš©μ„ μ •ν™•νžˆ μ „λ‹¬ν•©λ‹ˆλ‹€.
Description check βœ… Passed PR μ„€λͺ…에 κ΄€λ ¨ 이슈, μž‘μ—… λ‚΄μš©(Summary, Changes, Verification)이 λͺ¨λ‘ ν¬ν•¨λ˜μ–΄ μžˆμœΌλ‚˜, 리포지토리 ν…œν”Œλ¦Ώμ˜ 'κ΄€λ ¨ 이슈' μ„Ήμ…˜μ΄ λˆ„λ½λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection βœ… Passed βœ… No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/mentor-authstore-sync-main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant