-
Notifications
You must be signed in to change notification settings - Fork 29
NUI 6263 search component accessibility #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ludmilaFialova
wants to merge
26
commits into
main
Choose a base branch
from
bugfix/NUI-6263-search-component-accessibility_to_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
NUI 6263 search component accessibility #801
ludmilaFialova
wants to merge
26
commits into
main
from
bugfix/NUI-6263-search-component-accessibility_to_main
+3,494
−3,135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pavlo-poimanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image/popup/repeat should be fine but the search I'm not sure this changes will not cause problems. double check if all fine then ok.
also you can be a good camper and do next:
- make this true standalone components
- rewrite to signals control flow
- ngDestory => destroyRef
- inject() function
first camp fire rule - leave place better than it was before you ;)
pavlo-poimanov
previously approved these changes
Jan 26, 2026
db8d179 to
a7cca60
Compare
a7cca60 to
02e3e7d
Compare
20f738e to
3f1c29d
Compare
3f1c29d to
ef1531c
Compare
467efed to
169e3e2
Compare
169e3e2 to
12d0861
Compare
…h-component-accessibility_to_main
d65346d to
3fe7590
Compare
3fe7590 to
9477fd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://swicloud.atlassian.net/browse/NUI-6263
ER:
The Search button opens a pop-up when the Spacebar key is pressed.
The expanded search bar closes when the Esc key is pressed.
The buttons have sufficient contrast when focused.
The cancel button next to the Search bar is focusable by the Tab key and is called “Clear search button”
The magnifier icon next to the Search bar is hidden for the screen reader.
The buttons in the “Recent searches” area are accessible by the Tab key. I can get to the search by pressing the Enter or Space bar key. The caret-right icon is hidden.
When returning to some text in the search field, I hear: “Search edit selected all”
https://swicloud.atlassian.net/browse/OO-55517
ER:
The icon will be hidden for the SR. There will be no error in AXE DevTool.
Checklist