p-token: Update amount on self-unwrap lamports #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Dec 2, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just the one comment which you can take or leave
| // Comparing whether the AccountInfo's "point" to the same account or | ||
| // not - this is a faster comparison since it just checks the internal | ||
| // raw pointer. | ||
| if source_account_info != destination_account_info { |
Contributor
There was a problem hiding this comment.
Does it help CUs to tag this with likely?
Contributor
Author
There was a problem hiding this comment.
Nope, I tried that as well but the compiler is already doing the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As noted in this comment, the
amountis not decremented when executing a self-unwrap.Solution
Update the implementation to allow a self-unwrap to decrement the
amountof the account. Thelamportsof the account remain unchanged as expected.