Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lint toolchain in program lint script #83

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

buffalojoec
Copy link
Contributor

Problem

The program lint script at scripts/program/lint.mjs is using the toolchain for format instead of lint.

Summary of Changes

Update it to use lint!

#### Problem
The program lint script at `scripts/program/lint.mjs` is using the toolchain for `format` instead of `lint`.

#### Summary of Changes
Update it to use `lint`!
@buffalojoec buffalojoec requested a review from lorisleiva July 31, 2024 12:15
Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: df6c417

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-solana-program Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lorisleiva
Copy link
Member

Ah well spotted!

I've noticed there's the same issue with pnpm clients:rust:lint in this line:
https://github.com/solana-program/create-solana-program/blob/main/template/clients/rust/scripts/client/lint-rust.mjs#L15

Would you mind adding this to your PR? And also adding a changeset by running changeset locally.

@buffalojoec
Copy link
Contributor Author

Done!

Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dank je wel!

@lorisleiva lorisleiva merged commit afc1c6d into main Aug 1, 2024
6 checks passed
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants