Skip to content

Conversation

@aeither
Copy link

@aeither aeither commented Sep 25, 2022

Make scaffold compatible with latest routes breaking changes.
__ to +page.svelte
$app/env to $app/environment

@aeither aeither changed the title Update Svelte Kit to Latest Update SvelteKit to Latest Sep 25, 2022
Copy link
Collaborator

@silvestrevivo silvestrevivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeither thank you so much for this update. I think we should align the package.json with the official scaffold from SvelteKit ( scripts and packages versions ).

Another things like the alias, should be moved to the svelte.config.js file , look at the last updated documentation https://kit.svelte.dev/docs/configuration#alias

After that, please run npm run check to make sure there are no TS errors.

Thanks so much!!!!

Copy link
Collaborator

@silvestrevivo silvestrevivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeither please, can you update the package.json properly and aligned to the oficial scaffold? Please, look at the scrips and then at the packages versions. Thanks!!!

@aeither
Copy link
Author

aeither commented Sep 26, 2022

@silvestrevivo, I explained it in this line with link to the source. prettier-plugin-svelte is bundled in prettier-plugin-tailwindcss.
The dapp-scaffold-svelte comes with tailwindcss but users can't format classes. If someone want to format both svelte and tailwind, it can be done with prettier-plugin-tailwindcss. with svelte plugin you only format svelte.

image

prepare is redundant, the terminal asked me to remove it.

The versions are changed back and I also run npm run check which passed.

@silvestrevivo
Copy link
Collaborator

@aeither thank you so much for the explanation. I don't know why your text is not visible for me. Anyhow, I understand it much better. What I mean with the scripts from the package.json file, is that the "package": "svelte-kit package", it is removed in the last version of the scaffold.

The rest of the PR looks pretty great, thanks so much!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants