Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : call RPCModule::server_task_end() after serialize_meta() #364

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

holmes1412
Copy link
Contributor

@holmes1412 holmes1412 commented Mar 7, 2024

Also fix some bugs:

  1. call RPCModule::server_task_end() after serialize_meta(), otherwise some necessary http fields have not been set.
  2. new interface compatible : add path in RPCTraceOpenTelemetry in srpc/tools parsing config.
  3. set iterator for CounterVar in collector of RPCVar.
  4. RPCModule call server_end_response() in server_end().

@Barenboim Barenboim merged commit 8b382c5 into sogou:master Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants