Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rate limit #324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update rate limit #324

wants to merge 1 commit into from

Conversation

adamelfstrom
Copy link
Collaborator

The rate limit of the API has been increased from 4/s to 5/s a couple of years back.

In PR #258 this limit was increased in the SDK, but was shortly reverted due to concerns of inconsistencies between legacy tokens and the new OAuth2 workflow.
After some tests with both authentication methods, it seems they are both using the same sliding window now.

Closes #322

@adamelfstrom
Copy link
Collaborator Author

There might be a point in investigating if we should abandon the RateLimiter package since it seems to have been deprecated and might have some issues.

While testing I also ran in to an issue with this package as it seems to make requests a bit too quickly, resulting in a Too Many Requests error from the API if we set the requests per second to 5.

This is the reason for this PR increasing the requests per second to 4.8, rather than 5 (24 per 5 seconds instead of 25 per 5 seconds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit increased to 5
1 participant