Fix Choices Deserialization
#243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Breaking changes are fine in 0.x versions. Also, maybe there's a some chance to write a test? |
Some OpenAPI Compatible APIs like Ollama don't always return `lobprobs` as part of the `choices` JSON. To handle this we need to add a default argument to `logprobs` so upickle can handle this case. This PR moves the argument to the end which is breaking. This PR also adds an ollama deserialization test for completions.
kapunga
force-pushed
the
kapunga-fix-deserialization
branch
from
7b805e7 to
29e240e
Compare
Sounds good. I updated and added an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OpenAPI Compatible APIs like Ollama don't always return
lobprobsas part of thechoicesJSON. To handle this we need to add a default argument tologprobsso upickle can handle this case. A private case class is used to avoid having to change the order of arguments which would be a breaking change.