Max backoff for exponential backoffs #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… maximum wait time waited between retries.
macobo
force-pushed
the
karl-maxdelay-backoff
branch
from
789d440 to
c52e586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exponential backoffs are great for reducing load. However, problem with exponents is that they get large really fast - e.g. if your task fails 15 times you might end up waiting 9 hours instead 1 second between retries. After a certain point it doesn't really make sense anymore.
This PR adds a new optional
maxDelayargument to backoff policy - if provided and not infinite, it will only increase delays up to that given argument.EDIT: Not sure why tests fail, but a stack overflow does not happen locally. Given that travis has iterated in the past months, I'm assuming a bug there?