Update mocks #3854
Open
Update mocks #3854
+143
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
reviewed
Dec 5, 2025
|
|
||
|
|
||
| jest.mock('./lib/commonjs/RNGestureHandlerModule', () => | ||
| require('./lib/commonjs/mocks/mocks') |
Member
There was a problem hiding this comment.
- Can this be renamed from
mocks? - I don't think it should contain anything more than the module methods. The old gesture handlers, gesture-wrapped components, and host detector should be separate and mocked to the correct files, no?
I think the current setup dates back to the time when all of Gesture Handler was a single file, so it was correct to mock everything to a single file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates mocks to mock
HostGestureDetector, and have a separate file for mocking buttons. Moreover it adds tests for correct error throws in V3.Test plan
yarn test