Skip to content

fix(screenshot-diff): reject string values for captureBaseline/captureCurrent #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
latekvo merged 4 commits into from
Oct 23, 2026
Merged

fix(screenshot-diff): reject string values for captureBaseline/captureCurrent #1385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42c2533
fix(screenshot-diff): reject string values for captureBaseline/captur…
latekvo Oct 12, 2026
1846c55
test(screenshot-diff): reject a string capture flag
latekvo Oct 12, 2026
91d3bef
Merge branch 'main' into fix/screenshot-diff-strict-booleans
latekvo Oct 14, 2026
4627eef
Merge branch 'main' into fix/screenshot-diff-strict-booleans
latekvo Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/tool-server/src/tools/screenshot-diff/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,13 @@ const zodSchema = z
.describe(
"Target device id from `list-devices` (iOS UDID<flag:harmonyos>, HarmonyOS id,</flag:harmonyos> or Android serial)."
),
captureBaseline: z.coerce
captureBaseline: z
.boolean()
.optional()
.describe(
"Capture the baseline screenshot live at full resolution before diffing. Cannot be combined with captureCurrent."
),
captureCurrent: z.coerce
captureCurrent: z
.boolean()
.optional()
.describe(
Expand Down
11 changes: 11 additions & 0 deletions packages/tool-server/test/screenshot-diff-tool.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,17 @@ describe("screenshotDiffTool", () => {
expect(result.success).toBe(false);
});

it.each(["captureBaseline", "captureCurrent"])("rejects a string %s", (flag) => {
const result = screenshotDiffTool.zodSchema!.safeParse({
baselinePath: "/tmp/baseline.png",
currentPath: "/tmp/current.png",
udid: "ABC",
[flag]: "false",
});

expect(result.error?.issues).toMatchObject([{ code: "invalid_type", path: [flag] }]);
});

it("requires udid and only declares the simulator-server service for live captures", () => {
expect(
screenshotDiffTool.zodSchema!.safeParse({
Expand Down
Loading