refactor: abstract outline rendering #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwajgelt
added a commit
to software-mansion/radon-ide
that referenced
this pull request
Feb 26, 2025
Adds the "Outline Renders" tool which highlights React components when they are rendered. Based on [react-scan](https://github.com/aidenybai/react-scan) utility. - we reuse the [`react-scan`](https://github.com/aidenybai/react-scan) implementation of drawing the outlines on the canvas. Accessing it from our frontend code required abstracting the renderer code and exporting it from the package. These changes are available and pulled from a public fork the `react-scan` repository. software-mansion-labs/react-scan#1 - we use the [`bippy`](https://github.com/aidenybai/bippy) library for instrumenting the React rendering process. We include the built library code (extracted from the official release) in this repo in the `packages/vscode-extension/lib/bippy` directory and inject it into the RN Application bundle. We do it this way because it needs to be included in the final extension package in order to be injected into the RN application, and only the `lib` directory is available to Metro. ### How Has This Been Tested: - Open the "Tools" dropdown and toggle "Outline Renders". - Trigger component updates in the application. - The updated components should be briefly highlighted, with their names and update counter displayed. - Resizing the phone Preview should not break the outlines' positions. - The tool's enabled status should persist app, extension and IDE launches/reloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
canvas-related code out ofnew-outlines/index.tsand abstracts the canvas operations with anOutlineRendererinterface.