Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/android/nodes properties implementation #52

Merged
merged 8 commits into from
Jul 30, 2024

Conversation

maciejmakowski2003
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 commented Jul 29, 2024

-Added getters for numberOfInputs, numberOfOutputs and context in AudioNode
-Added getters fordefaultValue, minValue and maxValue in AudioParam
-Implemented state property in AudioContext
-Added getters for state and sampleRate in AudioContext
-Implemented getCurrentTimeMethod() in AudioContext
-Conducted small refactoring

Closes #48
Closes #47
Closes #46

Copy link
Member

@michalsek michalsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now lets ignore formatting in the docs, hope we will be able to setup proper documentation website soon :)

}

external fun initHybrid(): HybridData?
external fun install(jsContext: Long)

fun getCurrentTime(): Double {
return (SystemClock.elapsedRealtimeNanos() - contextStartTime)/1_000_000_000.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return (SystemClock.elapsedRealtimeNanos() - contextStartTime)/1_000_000_000.0
return (SystemClock.elapsedRealtimeNanos() - contextStartTime) / 1_000_000_000.0

:)

@maciejmakowski2003 maciejmakowski2003 merged commit 74e3819 into main Jul 30, 2024
2 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the feat/android/nodes-properties-implementation branch July 30, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants