-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/android/nodes properties implementation #52
Merged
maciejmakowski2003
merged 8 commits into
main
from
feat/android/nodes-properties-implementation
Jul 30, 2024
Merged
Feat/android/nodes properties implementation #52
maciejmakowski2003
merged 8 commits into
main
from
feat/android/nodes-properties-implementation
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsek
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now lets ignore formatting in the docs, hope we will be able to setup proper documentation website soon :)
} | ||
|
||
external fun initHybrid(): HybridData? | ||
external fun install(jsContext: Long) | ||
|
||
fun getCurrentTime(): Double { | ||
return (SystemClock.elapsedRealtimeNanos() - contextStartTime)/1_000_000_000.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
return (SystemClock.elapsedRealtimeNanos() - contextStartTime)/1_000_000_000.0 | |
return (SystemClock.elapsedRealtimeNanos() - contextStartTime) / 1_000_000_000.0 |
:)
maciejmakowski2003
deleted the
feat/android/nodes-properties-implementation
branch
July 30, 2024 12:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added getters for
numberOfInputs
,numberOfOutputs
andcontext
inAudioNode
-Added getters for
defaultValue
,minValue
andmaxValue
in AudioParam-Implemented
state
property inAudioContext
-Added getters for
state
andsampleRate
inAudioContext
-Implemented
getCurrentTimeMethod()
in AudioContext-Conducted small refactoring
Closes #48
Closes #47
Closes #46