Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/jsi and ts bugs #244

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Fix/jsi and ts bugs #244

merged 5 commits into from
Jan 7, 2025

Conversation

maciejmakowski2003
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 commented Jan 3, 2025 •
edited
Loading

Closes #237

Introduced changes

  • Added HostFunction caching
  • Removed unused ts components and files
  • Moved common ts files to common folders for all examples
  • Fixed Metronome example
  • Fixed start/stop mechanism bug

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

@maciejmakowski2003 maciejmakowski2003 changed the title Fix/jsi bugs Fix/jsi and ts bugs Jan 3, 2025
@maciejmakowski2003 maciejmakowski2003 marked this pull request as ready for review January 3, 2025 17:27
@maciejmakowski2003 maciejmakowski2003 self-assigned this Jan 3, 2025
@maciejmakowski2003 maciejmakowski2003 merged commit c9ab84f into main Jan 7, 2025
10 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the fix/jsi-bugs branch January 7, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsek michalsek michalsek approved these changes

Assignees

@maciejmakowski2003 maciejmakowski2003

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding HostFunction caching
2 participants
@maciejmakowski2003 @michalsek