refactor: added cleaning sourceNode

software-mansion-labs · Sep 30, 2024 · a8c597f · a8c597f
1 parent ac932b0
commit a8c597f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/react-native-audio-api/ios/nodes/GainNode/GainNode.m b/packages/react-native-audio-api/ios/nodes/GainNode/GainNode.m
@@ -33,7 +33,7 @@ - (void)process:(AVAudioFrameCount)frameCount bufferList:(AudioBufferList *)buff
 
     for (int bufferNum = 0; bufferNum < bufferList->mNumberBuffers; bufferNum += 1) {
       float *buffer = (float *)bufferList->mBuffers[bufferNum].mData;
-
+      
       buffer[frame] *= currentGain;
     }
 

diff --git a/packages/react-native-audio-api/ios/nodes/OscillatorNode/OscillatorNode.m b/packages/react-native-audio-api/ios/nodes/OscillatorNode/OscillatorNode.m
@@ -61,6 +61,7 @@ - (void)cleanup
   _frequencyParam = nil;
   _detuneParam = nil;
   _format = nil;
+  _sourceNode = nil;
 }
 
 - (OSStatus)renderCallbackWithIsSilence:(BOOL *)isSilence
@@ -104,8 +105,10 @@ - (OSStatus)renderCallbackWithIsSilence:(BOOL *)isSilence
           _phase += FULL_CIRCLE_RADIANS;
         }
   }
-
-  [self process:frameCount bufferList:outputData];
+
+  if (self.isPlaying) {
+    [self process:frameCount bufferList:outputData];
+  }
 
   return noErr;
 }
-Original file line number
+Diff line change
@@ Expand Up @@
         for (int bufferNum = 0; bufferNum < bufferList->mNumberBuffers; bufferNum += 1) {
           float *buffer = (float *)bufferList->mBuffers[bufferNum].mData;
           buffer[frame] *= currentGain;
         }
@@ Expand Down @@