Make image virtual size optional #331
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image `VirtualSize` is deprecated and `Size` is meant to be used as its replacement. In [newer versions of the API][1], `VirtualSize` is dropped completely, causing image listing and inspection to fail due to deserialization failures. [1]: https://docs.docker.com/engine/api/version-history/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Updated
ImageInfoandImageDetailsto makevirtual_sizeoptional and ensuresizeis available.The image
VirtualSizeis deprecated andSizeis meant to be used as its replacement. In newer versions of the API,VirtualSizeis dropped completely, causing image listing and inspection to fail due to deserialization failures.Closes: #xxx
How did you verify your change:
What (if anything) would need to be called out in the CHANGELOG for the next release:
virtual_sizeonImageInfoandImageDetailsis not optional andsizeshould be used instead.