Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,16 @@ public record MyProfileResponse(
@NotNull String nickname,
@NotNull Long industryId,
@NotNull Long jobCategoryId,
@NotNull String profileImageUrl) {
@NotNull String profileImageUrl,
@NotNull boolean isAgreedToTerms) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

원시 타입인 booleannull 값을 가질 수 없으므로 @NotNull 어노테이션은 불필요합니다. 이 어노테이션을 제거하여 코드를 더 명확하게 개선하는 것이 좋겠습니다.

Suggested change
@NotNull boolean isAgreedToTerms) {
boolean isAgreedToTerms) {

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스웨거상에 * 을 표시해주기 위해서 달아둔 어노테이션입니다~!


public static MyProfileResponse from(User user) {
return MyProfileResponse.builder()
.nickname(user.getNickname())
.industryId(user.getIndustry().getId())
.jobCategoryId(user.getJobCategory().getId())
.profileImageUrl(user.getProfileImageUrl())
.isAgreedToTerms(user.isAgreedToTerms())
.build();
}
}
Loading