Conversation
Summary of ChangesHello @w0uldy0u, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 Pull Request는 실시간 동시 편집 기능을 지원하기 위해 백엔드에 Redis 연동을 도입합니다. 주요 변경 사항은 Yjs 프로토콜을 사용하여 클라이언트로부터 수신되는 업데이트 프레임을 감지하고, 이를 Redis Stream에 기록하여 데이터의 일관성과 실시간 동기화를 보장하는 것입니다. 또한, 개발 및 스테이징 환경에서 Redis를 쉽게 배포하고 관리할 수 있도록 Docker Compose 설정을 업데이트했습니다. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
이 PR은 동시 편집 기능을 위해 Redis를 연동하여 Yjs 업데이트 프레임을 Redis Stream에 저장하는 작업을 포함합니다. 주요 변경 사항은 다음과 같습니다:
- Redis 의존성 및 설정 추가
CollaborationService가 업데이트 프레임을 Redis로 전송하도록 수정- Redis Stream 작업을 처리하는 새로운
RedisStreamStore추가 - 업데이트 프레임을 식별하기 위한
YjsProtocolUtil추가 - 로컬 및 스테이징 환경의
docker-compose.yml에 Redis 서비스 추가 (헬스 체크 및 서비스 의존성 설정 포함)
전반적으로 코드가 잘 구조화되어 있으며 애플리케이션의 안정성을 향상시키는 좋은 변경입니다. RedisStreamStore의 Redis 명령어 원자성 및 YjsProtocolUtil의 로직에 대해 몇 가지 제안 사항이 있습니다.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebf4fe8be1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
backend/api/src/main/java/com/yat2/episode/collaboration/config/CollaborationAsyncConfig.java
Show resolved
Hide resolved
backend/api/src/main/java/com/yat2/episode/collaboration/config/CollaborationAsyncConfig.java
Show resolved
Hide resolved
backend/api/src/main/java/com/yat2/episode/collaboration/config/CollaborationAsyncConfig.java
Show resolved
Hide resolved
backend/api/src/main/java/com/yat2/episode/collaboration/config/CollaborationAsyncConfig.java
Show resolved
Hide resolved
backend/api/src/main/java/com/yat2/episode/collaboration/CollaborationService.java
Show resolved
Hide resolved
backend/api/src/main/java/com/yat2/episode/collaboration/RedisStreamStore.java
Show resolved
Hide resolved
backend/api/src/main/java/com/yat2/episode/collaboration/CollaborationService.java
Show resolved
Hide resolved
backend/api/src/main/java/com/yat2/episode/collaboration/CollaborationService.java
Show resolved
Hide resolved
backend/api/src/main/java/com/yat2/episode/collaboration/RedisStreamStore.java
Show resolved
Hide resolved
…ub.com/softeerbootcamp-7th/Team2-Episode into feat/#356/use_redis_to_save_yjs_update
Closes #356
목적
작업 내용
결과