Conversation
…1-GENESIS into feat/#264/report-myself
…1-GENESIS into feat/#264/report-myself
Summary of ChangesHello @1jiwoo27, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 리포트 페이지에 '내 지출 리포트' 기능을 추가하고, 페이지 내에서 재사용 가능한 공통 UI 컴포넌트들을 분리하여 코드의 재사용성과 유지보수성을 향상시키는 데 중점을 둡니다. 특히, 월별 지출 비교를 위한 라인 그래프와 범례, 그리고 수직 그리드 컴포넌트가 새롭게 구현되거나 기존 컴포넌트에서 분리되어, 다양한 리포트 섹션에서 일관된 디자인과 기능을 제공할 수 있도록 기반을 마련했습니다. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
…Team1-Unipocket into feat/#264/report-myself
Kjiw0n
left a comment
Kjiw0n
left a comment
There was a problem hiding this comment.
수고하셨습니다! 👍 👍
코멘트 확인 부탁드려요.
분석파트 API명세 아직 안나온 것 같은데, mock과 유사한 방향으로 부탁드려도 될 것 같아요!
| interface ReportLegendProps { | ||
| color: keyof typeof LEGEND_COLOR; | ||
| label: string; | ||
| variant?: 'box' | 'line'; | ||
| } |
There was a problem hiding this comment.
color는 keyof typeof로 받고, variant는 직접 선언한 이유가 궁금합니다!
| interface ReportMyselfProps { | ||
| data: { | ||
| diff: string; | ||
| thisMonth: string; | ||
| thisMonthCount: number; | ||
| lastMonth: string; | ||
| lastMonthCount: number; | ||
| totalSpent: { | ||
| thisMonthToDate: string; | ||
| lastMonthTotal: string; | ||
| }; | ||
| thisMonthItem: ChartItem[]; | ||
| prevMonthItem: ChartItem[]; | ||
| }; | ||
| } |
There was a problem hiding this comment.
이번 달, 지난 달에 각각 {month, monthCount, monthItem} 을 들고있는 것 같아요.
해당 props들이 ReportMyselft -> ReportLineGraph -> ReportLineChart 로 내려가고 있는데, 공통으로 정의하면 더 알아보기 쉬울 것 같습니다!
+last/prev 용어 통일해주세요!
| <ReportLegend label="나" color="primary" /> | ||
| <ReportLegend label="다른 학생" color="secondary" /> |
There was a problem hiding this comment.
me&other과 primary&secondary 가 섞여서 사용되는 것 같은데, 구분되는 기준이 궁금합니다! 👀
2 participants
관련 이슈
closes #264
작업 내용
ReportLegendreport-page 내 공통 컴포넌트로 분리VerticalGridreport-page 내 공통 컴포넌트로 분리ReportMyself컴포넌트 구현컴포넌트 구조
ReportMyself → ReportLegend, VerticalGrid, ReportLineGraph → ReportLineChart
스크린샷
✨ 리뷰 포인트
💬 공유사항 to 리뷰어