Skip to content

fix: add path validation in VirtualAdapter.php #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soerennb merged 2 commits into from
Sep 7, 2026
Merged

fix: add path validation in VirtualAdapter.php #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
885da30
fix: V-001 security vulnerability
anupamme Sep 7, 2026
3125736
fix: validate mounted virtual paths
Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/Services/VFS/VirtualAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ private function resolveMount(string $path): array
$remaining = $parts[1] ?? '';

if (isset($this->mounts[$alias])) {
$remaining = PathPolicy::normalizeRelative($remaining);
return [$this->mounts[$alias], $remaining];
}

Expand Down
50 changes: 50 additions & 0 deletions tests/unit/VirtualVfsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@

class VirtualVfsTest extends CIUnitTestCase
{
private function assertTraversalBlocked(callable $operation): void
{
try {
$operation();
$this->fail('Expected mounted path traversal to be rejected.');
} catch (\RuntimeException $exception) {
$this->assertStringContainsString('traversal', strtolower($exception->getMessage()));
}
}

private function deleteTree(string $path): void
{
if (!file_exists($path)) {
Expand Down Expand Up @@ -88,4 +98,44 @@ public function testCopyCanCopyDirectoriesAcrossMounts(): void
$this->deleteTree($sourceRoot);
$this->deleteTree($targetRoot);
}

public function testMountedPathTraversalIsRejectedBeforeAnyOperationReachesTheAdapter(): void
{
$root = sys_get_temp_dir() . '/test_vfs_traversal_' . uniqid('', true);
mkdir($root, 0755, true);
file_put_contents($root . '/inside.txt', 'inside');

$vfs = new VirtualAdapter();
$vfs->mount('Test', new LocalAdapter($root));

$operations = [
static fn() => $vfs->listDirectory('Test/../outside'),
static fn() => $vfs->readFile('Test/../outside.txt'),
static fn() => $vfs->openReadStream('Test\\..\\outside.txt'),
static fn() => $vfs->writeFile('Test/../outside.txt', 'blocked'),
static fn() => $vfs->delete('Test/../outside.txt'),
static fn() => $vfs->createDirectory('Test/../outside'),
static fn() => $vfs->move('Test/../outside.txt', 'Test/inside.txt'),
static fn() => $vfs->move('Test/inside.txt', 'Test/../outside.txt'),
static fn() => $vfs->copy('Test/../outside.txt', 'Test/copy.txt'),
static fn() => $vfs->copy('Test/inside.txt', 'Test/../copy.txt'),
static fn() => $vfs->getMetadata('Test/../outside.txt'),
static fn() => $vfs->chmod('Test/../outside.txt', 0644),
static fn() => $vfs->chown('Test/../outside.txt', 'user', 'group'),
static fn() => $vfs->getDirectorySize('Test/../outside'),
static fn() => $vfs->archive(['Test/../outside.txt'], 'Test/archive.zip'),
static fn() => $vfs->extract('Test/archive.zip', 'Test/../outside'),
static fn() => $vfs->resolvePath('Test\\..\\outside.txt'),
];

foreach ($operations as $operation) {
$this->assertTraversalBlocked($operation);
}

$this->assertFileDoesNotExist(dirname($root) . '/outside.txt');
$this->assertFileDoesNotExist($root . '/outside.txt');
$this->assertFileExists($root . '/inside.txt');

$this->deleteTree($root);
}
}
Loading