This repository was archived by the owner on Mar 26, 2024. It is now read-only.
[WIP] various GNU/Linux Debian package improvements#377
Open
ZeroPointEnergy wants to merge 1 commit intosodabrew:masterfrom
Open
[WIP] various GNU/Linux Debian package improvements#377ZeroPointEnergy wants to merge 1 commit intosodabrew:masterfrom
ZeroPointEnergy wants to merge 1 commit intosodabrew:masterfrom
Conversation
This was referenced Sep 11, 2018
smortex
reviewed
Sep 12, 2019
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
I spotted a few minor things when browsing this issue. I added in-line comments.
| # config/database.yml | ||
| # | ||
| # IMPORTANT NOTE: Before starting Dashboard, you will need to ensure that the | ||
| # MySQL user and databases you've specified in this file exist, and that the |
There was a problem hiding this comment.
This note is providing instructions for MySQL, but the sample entries bellow are PostgreSQL related
| @@ -0,0 +1,15 @@ | |||
| i#!/bin/bash | |||
There was a problem hiding this comment.
Unexpected i a the beginning of the line… bash does not seems to be required, would not /bin/sh suffice?
| @@ -0,0 +1,15 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
bash does not seems to be required, would not /bin/sh suffice?
Collaborator
Author
|
Hi @smortex sorry for the late reply and thanks for the review. This PR was extracted from some older PR from another person and no one is currently working on it but everyone if very welcome to take it over and work on it :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the Debian package improvement part of the PR #333 . I did not test this so far. The reason for this PR is to separate the code out of #333 so we can review, test and discuss it better.
THIS WORK IN PROGRESS!
This PR is not tested and should not be merged currently.