This repository was archived by the owner on Mar 26, 2024. It is now read-only.
[WIP] Support purge:orphaned for postgresql#376
Open
ZeroPointEnergy wants to merge 1 commit intosodabrew:masterfrom
Open
[WIP] Support purge:orphaned for postgresql#376ZeroPointEnergy wants to merge 1 commit intosodabrew:masterfrom
ZeroPointEnergy wants to merge 1 commit intosodabrew:masterfrom
Conversation
bwitt
reviewed
Sep 11, 2018
| DELETION_BATCH_SIZE = 1000 | ||
| while deletion_count > 0 | ||
| ActiveRecord::Base.connection.execute( | ||
| "DELETE FROM #{model.table_name} USING #{model.table_name} WHERE #{deletion_where_clause}" |
Collaborator
There was a problem hiding this comment.
looks like this removes the batch part of the delete
Collaborator
There was a problem hiding this comment.
ah postgresql doesn't support that! yikes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the purge:orphaned part of the PR #333 . I did not test this so far. The reason for this PR is to separate the code out of #333 so we can review, test and discuss it better.
THIS WORK IN PROGRESS!
This PR is not tested and should not be merged currently.