Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos of the documentation and adding equations to GradientBoostingIncidence #22

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

juAlberge
Copy link
Collaborator

No description provided.

@juAlberge juAlberge marked this pull request as ready for review November 8, 2023 13:04
Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if that fixes the "math input error" on the rendered HTML doc.

hazardous/_gradient_boosting_incidence.py Show resolved Hide resolved
hazardous/_gradient_boosting_incidence.py Outdated Show resolved Hide resolved
hazardous/_gradient_boosting_incidence.py Outdated Show resolved Hide resolved
hazardous/_gradient_boosting_incidence.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @juAlberge. Here are some more refinements:

hazardous/_gradient_boosting_incidence.py Outdated Show resolved Hide resolved
hazardous/_gradient_boosting_incidence.py Outdated Show resolved Hide resolved
hazardous/_gradient_boosting_incidence.py Show resolved Hide resolved
@ogrisel ogrisel merged commit 082e83d into soda-inria:main Nov 8, 2023
7 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 8, 2023
Fixing typos of the documentation and adding equations to GradientBoostingIncidence 082e83d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants