Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(CONTRIBUTING.md): add build instructions #635

Merged
merged 5 commits into from
Oct 4, 2023
Merged

docs(CONTRIBUTING.md): add build instructions #635

merged 5 commits into from
Oct 4, 2023

Conversation

chicoxyzzy
Copy link
Member

@chicoxyzzy chicoxyzzy commented Oct 3, 2023 •
edited
Loading

@chicoxyzzy chicoxyzzy added the documentation Improvements or additions to documentation label Oct 3, 2023
@chicoxyzzy chicoxyzzy requested review from heapwolf and bcomnes October 3, 2023 17:05
@bcomnes
Copy link
Contributor

bcomnes commented Oct 3, 2023

Reading

bcomnes
bcomnes approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should you mention how to link?

./bin/publish-npm-modules.sh --link

@jwerle
Copy link
Member

jwerle commented Oct 3, 2023

LGTM, but should you mention how to link?

./bin/publish-npm-modules.sh --link

yeah this is pretty important for local development (typings, local module, etc)

@bcomnes
Copy link
Contributor

bcomnes commented Oct 3, 2023 •
edited
Loading

I aliased it to npm relink which is a little easier to remember but none of the other commands are aliased to npm scripts. Maybe we should decide if alias all or none.

Whats here is good though.

@chicoxyzzy chicoxyzzy merged commit becf9d3 into master Oct 4, 2023
@chicoxyzzy chicoxyzzy deleted the contrib branch October 4, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwerle jwerle jwerle approved these changes

@bcomnes bcomnes bcomnes approved these changes

@heapwolf heapwolf Awaiting requested review from heapwolf

Assignees

@jwerle jwerle

@chicoxyzzy chicoxyzzy

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chicoxyzzy @bcomnes @jwerle