Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer thread current raise #30

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Prefer thread current raise #30

merged 2 commits into from
Feb 20, 2024

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Feb 20, 2024 •
edited
Loading

I'm investigating some odd shutdown behaviour in async-job when integrated with Rails. An exception is being raised during Thread.handle_interrupt incorrectly. Using Thread.current.raise prevents this.

Types of Changes

  • Bug fix.

Contribution

@ioquatix ioquatix force-pushed the prefer-thread-current-raise branch from bf9ee15 to 335b640 Compare February 20, 2024 13:09
@ioquatix ioquatix merged commit f0b4b5e into main Feb 20, 2024
41 of 48 checks passed
@ioquatix ioquatix deleted the prefer-thread-current-raise branch February 20, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ioquatix