SNOW-1904191:[API Coverage] functions coverage #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-yuwang
requested review from
sfc-gh-smirzaei,
sfc-gh-jdu and
sfc-gh-jrose
src/snowflake/snowpark/dataframe.py
Outdated
Comment on lines
1417
to
1421
| elif isinstance(e, (list, tuple, set)): | ||
| for sub_e in e: | ||
| names.append(sub_e._named()) | ||
| if _emit_ast and _ast_stmt is None: | ||
| ast_cols.append(sub_e._ast) |
There was a problem hiding this comment.
how does this change affect this new funcs?
There was a problem hiding this comment.
json_tuple will have to return a list of columns, while our select function currently does not support this form of call:
df.select(col1, [col2,col3]), this is meant to support it
sfc-gh-aalam
reviewed
Feb 1, 2025
CHANGELOG.md
Outdated
Comment on lines
46
to
45
| - `array_slice` | ||
| - `try_to_binary` |
There was a problem hiding this comment.
did this change get removed?
There was a problem hiding this comment.
+ need to update functions.rst?
There was a problem hiding this comment.
I found out that we already support it, so I removed it from this PR
sfc-gh-jrose
approved these changes
Feb 3, 2025
sfc-gh-aalam
approved these changes
Feb 4, 2025
src/snowflake/snowpark/functions.py
Outdated
Comment on lines
707
to
709
| max_bit = bitshiftleft(lit(1), 64) | ||
| unsigned_c = iff(c < 0, bitshiftright(c + max_bit, n), bitshiftright(c, n)) | ||
| return call_builtin("bitand", unsigned_c, max_bit - 1, _emit_ast=_emit_ast) |
There was a problem hiding this comment.
Suggested change
| max_bit = bitshiftleft(lit(1), 64) | |
| unsigned_c = iff(c < 0, bitshiftright(c + max_bit, n), bitshiftright(c, n)) | |
| return call_builtin("bitand", unsigned_c, max_bit - 1, _emit_ast=_emit_ast) | |
| max_bit = bitshiftleft(lit(1, _emit_ast=False), 64, _emit_ast=False) | |
| unsigned_c = iff(c < 0, bitshiftright(c + max_bit, n, _emit_ast=False), bitshiftright(c, n, _emit_ast=False), _emit_ast=False) | |
| return call_builtin("bitand", unsigned_c, max_bit - 1, _emit_ast=_emit_ast) |
let's make sure that for all internal calls to our functions, we set _emit_ast=False
src/snowflake/snowpark/functions.py
Outdated
| """ | ||
| c = _to_col_if_str(col, "json_tuple") | ||
| return [ | ||
| json_extract_path_text(parse_json(c), lit(field)).as_(f"c{i}") |
There was a problem hiding this comment.
same here, _emit_ast=False
sfc-gh-heshah
requested changes
Feb 4, 2025
sfc-gh-yuwang
force-pushed
the
SNOW-1904191
branch
from
08643fc to
dcc317c
Compare
sfc-gh-heshah
approved these changes
Feb 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1904191
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.