Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1899609 Bump bpckix-fips #1049

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SNOW-1899609 Bump bpckix-fips #1049

wants to merge 2 commits into from

Conversation

sfc-gh-rsawicki
Copy link
Contributor

@sfc-gh-rsawicki sfc-gh-rsawicki commented Jan 31, 2025 •
edited by jira bot
Loading

Overview

SNOW-1899609

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-rsawicki sfc-gh-rsawicki requested a review from a team as a code owner January 31, 2025 08:01
sfc-gh-mbobowski
sfc-gh-mbobowski reviewed Feb 4, 2025
View reviewed changes
pom.xml
@@ -276,7 +276,7 @@
<dependency>
<groupId>org.bouncycastle</groupId>
<artifactId>bcpkix-fips</artifactId>
<version>1.0.3</version>
<version>2.1.8</version>
Copy link
Contributor

@sfc-gh-mbobowski sfc-gh-mbobowski Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think we should also upgrade bc-fips (EDIT - we don't depend on it)
  2. And downloaded version in run_test_apache.sh so we can actually test it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we need to update the docs: https://docs.snowflake.com/en/user-guide/kafka-connector-install#download-the-kafka-connector-files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confluent still recommends using 1.0.2, so we have to ask them first https://docs.snowflake.com/en/user-guide/kafka-connector-install#download-the-kafka-connector-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mbobowski sfc-gh-mbobowski sfc-gh-mbobowski left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-rsawicki @sfc-gh-mbobowski