Catch OOM and consider it a pass (twitter#614)

snoble · Jan 13, 2017 · f1147b4 · f1147b4
1 parent 1be041f
commit f1147b4
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/algebird-test/src/test/scala/com/twitter/algebird/SpaceSaverTest.scala b/algebird-test/src/test/scala/com/twitter/algebird/SpaceSaverTest.scala
@@ -46,9 +46,13 @@ class SpaceSaverLaws extends CheckProperties {
 
   property("SpaceSaver.fromBytes yield a failure on bad Array[Byte]") {
     forAll { a: Array[Byte] =>
-      val fromBytes = SpaceSaver.fromBytes(a, SpaceSaverTest.arrayByteToString)
-      //We check that `fromBytes` doesn't yield exceptions
-      fromBytes.isFailure || fromBytes.isSuccess
+      try {
+        val fromBytes = SpaceSaver.fromBytes(a, SpaceSaverTest.arrayByteToString)
+        //We check that `fromBytes` doesn't yield exceptions
+        fromBytes.isFailure || fromBytes.isSuccess
+      } catch {
+        case oom: OutOfMemoryError => true // this happens if random data has a giant number in it
+      }
     }
   }
 }
@@ -100,4 +104,4 @@ object SpaceSaverTest {
 
   def arrayByteToString(a: Array[Byte]): Try[String] = Try(new String(a, "UTF-8"))
 
-}
+}