feat: orchestrate full GSD lifecycle in execute_gsd_milestone#53
Merged
snipcodeit merged 3 commits intomainfrom Feb 27, 2026
Merged
feat: orchestrate full GSD lifecycle in execute_gsd_milestone#53snipcodeit merged 3 commits intomainfrom
snipcodeit merged 3 commits intomainfrom
Conversation
added 2 commits
February 26, 2026 22:41
…lifecycle - Add roadmap analyze to discover phases from ROADMAP.md - Add init plan-phase per phase with mkdir -p for directory creation - Spawn gsd-planner agents with plan-phase workflow reference - Add init execute-phase before spawning gsd-executor agents - Spawn gsd-verifier agents with verify-phase workflow reference - Add plan count check after planning to guard against empty phases - Preserve existing preamble (model resolution, milestone init, ROADMAP creation checkpoint)
…line pattern - Add sub-step 3 in milestone.md post_loop to call gsd:complete-milestone when .planning/phases exists, with EXECUTOR_MODEL resolved via gsd-tools before Task() spawn; renumber former steps 3-5 to 4-6, former 6 to 7 - Expand GSD Milestone Pipeline Pattern in gsd.md from 3-step skeleton to full lifecycle with phase discovery, per-phase init/plan/execute/verify loop, explicit init execute-phase call, artifact listing per phase, and milestone completion artifacts - Update gsd.md Consumers table to include milestone.md
Owner
Author
Testing ProceduresPre-requisites
Test 1: execute_gsd_milestone creates phase directories
Test 2: milestone.md completion hook
Test 3: Model resolution
Test 4: Regression — quick route unaffected
|
init plan-phase returns phase_dir: null when the directory doesn't exist yet, causing mkdir -p to silently fail. Use scaffold phase-dir first (which creates the directory from ROADMAP data and returns the path), then call init plan-phase for model resolution. Found during mgw-test pipeline run (issue #91, PR #92). Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execute_gsd_milestonestep incommands/run.mdwith a concrete per-phase loop that discovers phases viaroadmap analyze, creates.planning/phases/directories viainit plan-phase+init execute-phase, and spawnsgsd-planner/gsd-executor/gsd-verifieragents per phasegsd:complete-milestonehook tocommands/milestone.mdpost_loop (resolvesEXECUTOR_MODELbefore spawn, guarded by.planning/phasesexistence check)workflows/gsd.mdto full 6-step lifecycle documentationCloses #52
Changes
commands/run.mdexecute_gsd_milestonewith concrete per-phase loopinit plan-phase→mkdir -p→gsd-plannerTask() → plan count guard →init execute-phase→gsd-executorTask() →gsd-verifierTask() → phase comment postnode gsd-tools.cjs roadmap analyzecommands/milestone.mdpost_loop(between draft release and advance pointer)EXECUTOR_MODELviaresolve-model gsd-executorbefore spawning agentgsd-executoragent runsgsd:complete-milestoneworkflow to archive phase directories.planning/phasesexistence check (no-op if no phases exist).claude/commands/mgw/workflows/gsd.mdmilestone.mdTest Plan
/mgw:runon an issue that routes togsd:new-milestone— verify.planning/phases/directories are created per ROADMAP phase/mgw:milestonecompletion flow — verifygsd:complete-milestonehook fires and archives phase directoriesgsd:progressshows correct phase state after milestone executionresolve-model gsd-executor) resolves correctly in milestone.md contextVerification
5/5 must-haves verified:
execute_gsd_milestoneorchestrates full lifecycle (plan → execute → verify per phase)init plan-phase+mkdir -pmilestone.mdcallsgsd:complete-milestonevia executor agentEXECUTOR_MODELresolved before Task() spawn in milestone.mdgsd.mddocuments full lifecycle pattern