Skip to content

Conversation

@hombit
Copy link
Member

@hombit hombit commented Dec 2, 2025

  • Update Rust Edition to 2024 (requires Rust 1.85+)
  • Update PyO3 and rust-numpy to 0.27 (in theory more interpreter versions are supported, but we still build for CPython ABI3 3.10+ only)
  • Update ndarray to 0.17

@hombit hombit marked this pull request as draft December 2, 2025 15:46
@hombit hombit marked this pull request as ready for review December 2, 2025 19:52
@hombit hombit requested a review from matwey December 2, 2025 19:52
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2025

CodSpeed Performance Report

Merging #295 will improve performances by ×18

Comparing update-rust-deps (1427a7e) with master (c78dece)1

🎉 Hooray! pytest-codspeed just leveled up to 4.2.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

⚡ 44 improvements
✅ 3 untouched
⏩ 4 skipped2

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Simulation test_benchmark_fit_known 266.8 ms 92.1 ms ×2.9
Simulation test_benchmark_feature_signature[128] 555.7 µs 410.4 µs +35.41%
Simulation test_benchmark_feature_signature[2] 563.4 µs 413.4 µs +36.29%
Simulation test_benchmark_fit_sklearn[1024] 5.3 s 4.5 s +17.09%
Simulation test_benchmark_fit_sklearn[128] 668.1 ms 570.6 ms +17.09%
Simulation test_benchmark_score[1024] 8.5 ms 7 ms +22.02%
Simulation test_benchmark_score[1048576] 8.4 s 6.9 s +21.16%
Simulation test_benchmark_score_samples[1-128-1024] 9.8 ms 8.3 ms +18.56%
Simulation test_benchmark_score_samples[1-128-1048576] 9.7 s 8.3 s +17.57%
Simulation test_benchmark_score_samples[1-128-1] 264.8 µs 128.9 µs ×2.1
Simulation test_benchmark_score_samples[1-128-32] 614.1 µs 458.6 µs +33.92%
Simulation test_benchmark_score_samples[1-256-1024] 18 ms 15.1 ms +19.7%
Simulation test_benchmark_score_samples[1-256-1048576] 17.9 s 15 s +19.39%
Simulation test_benchmark_score_samples[1-256-1] 276.2 µs 161.4 µs +71.12%
Simulation test_benchmark_score_samples[1-256-32] 978.7 µs 775.8 µs +26.15%
Simulation test_benchmark_score_samples[1-64-1024] 5.6 ms 4.8 ms +17.97%
Simulation test_benchmark_score_samples[1-64-1048576] 5.5 s 4.7 s +15.8%
Simulation test_benchmark_score_samples[1-64-1] 223.6 µs 111.6 µs ×2
Simulation test_benchmark_score_samples[1-64-32] 428.6 µs 294.3 µs +45.63%
Simulation test_benchmark_score_samples[2-128-1024] 10.1 ms 8.3 ms +22.08%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. No successful run was found on master (399502c) during the generation of this report, so c78dece was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@matwey
Copy link
Contributor

matwey commented Dec 3, 2025

LGTM

@matwey matwey merged commit f449fd4 into master Dec 3, 2025
38 checks passed
@matwey matwey deleted the update-rust-deps branch December 3, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants