Skip to content

Conversation

@Jadon-Chan
Copy link
Contributor

@Jadon-Chan Jadon-Chan commented Oct 12, 2025

I migrate the BBR implementation in quinn in.

After further investigation, there are several problems after this migration. The most essential one is that: smoltcp doesn't have any pacing mechanism at all. Without pacing, BBR cannot be completely implemented.

For more information about TCP pacing, here is a paper TCP Pacing in the Linux Kernel

@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 67.79661% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.40%. Comparing base (17012eb) to head (136f17a).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/socket/tcp.rs 60.41% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
- Coverage   80.45%   80.40%   -0.06%     
==========================================
  Files          81       81              
  Lines       24461    24523      +62     
==========================================
+ Hits        19681    19717      +36     
- Misses       4780     4806      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant