Skip to content

fix: exhaust egress socket state on poll #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomaseizinger
Copy link
Contributor

At present, smoltcp only does a single pass of advancing the egress socket state. This means the layer above has to call poll in a loop to ensure sufficient progress has been made.

We already exhaustively progress the ingress state further up so doing the same thing for the egress state seems appropriate.

Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (e2b75e3) to head (e528210).

Files with missing lines Patch % Lines
src/iface/interface/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   81.17%   81.17%           
=======================================
  Files          81       81           
  Lines       28955    28955           
=======================================
  Hits        23503    23503           
  Misses       5452     5452           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant