-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CJK character is not rendered correctly #140
Comments
So, in trying to fix this, I've learned that (1) a WebGL renderer is a major reason why uivonim is as fast as it is, and removing that would make it much slower, especially considering my optimization skills (or lack thereof), and (2) that I have no idea how to fix this with WebGL. The ideas I've come up with/tried just aren't ideal, or don't work, or both. Trying to render double-width chars in a single pass of the current renderer is really difficult, if not impossible (and if it is possible I don't know enough about WebGL to make it work), and even if it did work I'm guessing it would add a lot of Doing two render passes with separate shaders would be ideal probably, kind of like what Goneovim does, where the CJK chars are rendered separately after non-CJK chars, but I have no idea how to make that work. I can't really have two grid buffers, because (a) that would be inefficient probably and (b) a pain to deal with. I could maybe have a Overall this just feels outside my area of understanding, unfortunately, even after having read up on WebGL. I feel like I have a decent grasp on what's happening, but fixing the issue is not trivial, it seems, at least for me. |
Adds new font atlas & modifies rendering code to deal with CJK chars. Fix #140. TODO: Text rendering quality seems to look worse for some reason on my 1080p display but not my MBA? Maybe just me but something to look into.
Here is the file content:
Open it with uivonim:
Enviornment:
The text was updated successfully, but these errors were encountered: