Fix specific permlink collision on create

steemit/condenser#3286 steemit/condenser#3303
smokenetwork · Aug 5, 2020 · 0c09ae0 · 0c09ae0
1 parent c223451
commit 0c09ae0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/app/redux/TransactionSaga.js b/src/app/redux/TransactionSaga.js
@@ -449,6 +449,8 @@ function* createPermlink(title, author, parent_author, parent_permlink) {
     if (s === '') {
       s = base58.encode(secureRandom.randomBuffer(4))
     }
+    // only letters numbers and dashes shall survive
+    s = s.toLowerCase().replace(/[^a-z0-9-]+/g, '');
     // ensure the permlink(slug) is unique
     const slugState = yield call([api, api.getContentAsync], author, s)
     let prefix
@@ -461,16 +463,14 @@ function* createPermlink(title, author, parent_author, parent_permlink) {
     permlink = prefix + s
   } else {
     // comments: re-parentauthor-parentpermlink-time
-    const timeStr = new Date().toISOString().replace(/[^a-zA-Z0-9]+/g, '')
+    const timeStr = new Date().toISOString().replace(/[^a-zA-Z0-9]+/g, '').toLowerCase();
     parent_permlink = parent_permlink.replace(/(-\d{8}t\d{9}z)/g, '')
     permlink = `re-${parent_author}-${parent_permlink}-${timeStr}`
   }
   if (permlink.length > 255) {
     // SMOKE_MAX_PERMLINK_LENGTH
     permlink = permlink.substring(permlink.length - 255, permlink.length)
   }
-  // only letters numbers and dashes shall survive
-  permlink = permlink.toLowerCase().replace(/[^a-z0-9-]+/g, '')
   return permlink
 }