Add CI to build against api-models-aws #2606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a job to the CI workflow that builds https://github.com/aws/api-models-aws using new Smithy changes. api-models-aws is a pretty large test suite, so this should give us much more confidence that we aren't making breaking changes to a validator or something.
milesziemer
force-pushed
the
api-models-ci
branch
from
26423cb to
ca71fe4
Compare
haydenbaker
approved these changes
May 9, 2025
|
I wonder if we could pTML from the 17 build, and then cache that so build doesn't have to be done twice. Nevertheless, an optimization we can look at later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a job to the CI workflow that builds https://github.com/aws/api-models-aws using new Smithy changes.
api-models-aws is a pretty large test suite, so this should give us much more confidence that we aren't making breaking changes to a validator or something.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.