Skip to content

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Sep 30, 2025

Issue #, if available:
N/A

Description of changes:
Removes usage of deprecated APIs

Before

$ smithy-typescript> ./gradlew publishToMavenLocal

> Task :smithy-typescript-codegen:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

[Incubating] Problems report is available at: file:///local/home/trivikr/workspace/smithy-typescript/build/reports/problems/problems-report.html

BUILD SUCCESSFUL in 3s

After

$ smithy-typescript> ./gradlew publishToMavenLocal

BUILD SUCCESSFUL in 7s

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner September 30, 2025 22:51
@trivikr

This comment was marked as outdated.

@trivikr trivikr closed this Sep 30, 2025
@trivikr trivikr deleted the remove-deprecated-apis branch September 30, 2025 23:36
@trivikr trivikr restored the remove-deprecated-apis branch September 30, 2025 23:37
@trivikr trivikr reopened this Sep 30, 2025
.map(trait -> Format.fromString(trait.getValue()))
.orElse(defaultTimestampFormat);
return HttpProtocolGeneratorUtils.getTimestampInputParam(context, dataSource, shape, format);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be this:

no codegen diff in all aws sdks?

    @Override
    public String timestampShape(TimestampShape shape) {
        Format format = shape.getMemberTrait(context.getModel(), TimestampFormatTrait.class)
            .map(TimestampFormatTrait::getFormat)
            .orElse(defaultTimestampFormat);
        
        return HttpProtocolGeneratorUtils.getTimestampInputParam(context, dataSource, shape, format);
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants